AbleOS/holey-toys
2
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

better is_neg handling

Browse source
This commit is contained in:
Igor Malovitsa 2024-03-06 10:59:17 +02:00
parent c0692c9ffd
commit 4283c17739
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
hbas.c
View file

@ -658,13 +658,9 @@ AsmError assemble_instr(
ArgMeta meta = arg_meta(chr); ArgMeta meta = arg_meta(chr);
uint64_t is_negative = 0; uint64_t is_negative = 0;
*tok = token(input, len, tok->start + tok->len); *tok = token(input, len, tok->start + tok->len);
while (!is_negative) { if (tok->kind == TokNeg) {
if (tok->kind == TokNeg) { *tok = token(input, len, tok->start + tok->len);
*tok = token(input, len, tok->start + tok->len); is_negative = ~(uint64_t)0;
is_negative = ~(uint64_t)0;
} else {
break;
}
} }
if (chr == 'R') { if (chr == 'R') {
int reg = parse_register(&input[tok->start], tok->len); int reg = parse_register(&input[tok->start], tok->len);
@ -709,7 +705,11 @@ AsmError assemble_instr(
} }
// num_to_write = num_to_write ^ is_negative - is_negative; // num_to_write = num_to_write ^ is_negative - is_negative;
if (is_negative) { if (is_negative) {
num_to_write = (uint64_t)(-(int64_t)num_to_write); int64_t tmp = (int64_t)num_to_write;
if (tmp < 0) {
return ErrBadNumOverflow;
}
num_to_write = (uint64_t)(-tmp);
} }
AsmError err = push_int_le( AsmError err = push_int_le(
&rv->buf[rv->len], num_to_write, meta.size, meta.sign &rv->buf[rv->len], num_to_write, meta.size, meta.sign