From 699855669b97906e4f3477369b49d34d2ef8d4b2 Mon Sep 17 00:00:00 2001 From: Ryan Kennedy Date: Wed, 25 Mar 2020 16:50:35 -0500 Subject: [PATCH] Fixing comments --- src/writers/graphics_640x480x16.rs | 4 ++++ src/writers/mod.rs | 7 +------ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/writers/graphics_640x480x16.rs b/src/writers/graphics_640x480x16.rs index f7edd28..8000b6b 100644 --- a/src/writers/graphics_640x480x16.rs +++ b/src/writers/graphics_640x480x16.rs @@ -87,6 +87,10 @@ impl GraphicsWriter for Graphics640x480x16 { } } + /// **Note:** This method is provided for convenience, but has terrible + /// performance since it needs to ensure the correct `WriteMode` per pixel + /// drawn. If you need to draw more then one pixel, consider using a method + /// such as `draw_line`. fn set_pixel(&self, x: usize, y: usize, color: Color16) { self.set_write_mode_2(); self._set_pixel(x, y, color); diff --git a/src/writers/mod.rs b/src/writers/mod.rs index ac5b14b..c6c6efa 100644 --- a/src/writers/mod.rs +++ b/src/writers/mod.rs @@ -185,16 +185,11 @@ pub trait TextWriter: Screen { pub trait GraphicsWriter { /// Clears the screen by setting all pixels to the specified `color`. fn clear_screen(&self, color: Color); - /// /// Draws a line from `start` to `end` with the specified `color`. + /// Draws a line from `start` to `end` with the specified `color`. fn draw_line(&self, start: Point, end: Point, color: Color); /// Draws a character at the given `(x, y)` coordinant to the specified `color`. fn draw_character(&self, x: usize, y: usize, character: char, color: Color); /// Sets the given pixel at `(x, y)` to the given `color`. - /// - /// **Note:** This method is provided for convenience, but has terrible - /// performance since it needs to ensure the correct `WriteMode` per pixel - /// drawn. If you need to draw more then one pixel, consider using a method - /// such as `draw_line`. fn set_pixel(&self, x: usize, y: usize, color: Color); /// Sets the graphics device to a `VideoMode`. fn set_mode(&self);