From c5ac6f3fe13465256dd7ee4e07893bf19908c8c8 Mon Sep 17 00:00:00 2001 From: bendn Date: Tue, 5 Sep 2023 08:28:27 +0700 Subject: [PATCH] segfaulting --- Cargo.toml | 7 ++ {test_data => benches}/3_4x4.imgbuf | 0 .../3x3_at_out.imgbuf | 0 {test_data => benches}/4_4x4.imgbuf | 0 .../4x3_at_out.imgbuf | 0 .../4x4_at_out.imgbuf | 0 benches/overlays.rs | 65 ++++++++++++++++ src/overlay.rs | 78 ------------------- 8 files changed, 72 insertions(+), 78 deletions(-) rename {test_data => benches}/3_4x4.imgbuf (100%) rename test_results/3x3_at_out.buf => benches/3x3_at_out.imgbuf (100%) rename {test_data => benches}/4_4x4.imgbuf (100%) rename test_results/4x3_at_out.buf => benches/4x3_at_out.imgbuf (100%) rename test_results/4x4_at_out.buf => benches/4x4_at_out.imgbuf (100%) create mode 100644 benches/overlays.rs diff --git a/Cargo.toml b/Cargo.toml index 1c85e52..ab92c06 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -12,6 +12,13 @@ repository = "https://github.com/bend-n/fimg" [dependencies] png = { version = "0.17", features = ["unstable"], optional = true } +[dev-dependencies] +criterion = "0.5" + +[[bench]] +name = "overlays" +harness = false + [features] save = ["png"] default = ["save"] diff --git a/test_data/3_4x4.imgbuf b/benches/3_4x4.imgbuf similarity index 100% rename from test_data/3_4x4.imgbuf rename to benches/3_4x4.imgbuf diff --git a/test_results/3x3_at_out.buf b/benches/3x3_at_out.imgbuf similarity index 100% rename from test_results/3x3_at_out.buf rename to benches/3x3_at_out.imgbuf diff --git a/test_data/4_4x4.imgbuf b/benches/4_4x4.imgbuf similarity index 100% rename from test_data/4_4x4.imgbuf rename to benches/4_4x4.imgbuf diff --git a/test_results/4x3_at_out.buf b/benches/4x3_at_out.imgbuf similarity index 100% rename from test_results/4x3_at_out.buf rename to benches/4x3_at_out.imgbuf diff --git a/test_results/4x4_at_out.buf b/benches/4x4_at_out.imgbuf similarity index 100% rename from test_results/4x4_at_out.buf rename to benches/4x4_at_out.imgbuf diff --git a/benches/overlays.rs b/benches/overlays.rs new file mode 100644 index 0000000..2236905 --- /dev/null +++ b/benches/overlays.rs @@ -0,0 +1,65 @@ +use criterion::{criterion_group, criterion_main, Criterion}; +use fimg::*; + +pub fn criterion_benchmark(bench: &mut Criterion) { + let mut group = bench.benchmark_group("overlays"); + { + let mut a: Image<_, 3> = Image::alloc(64, 64); + let b = Image::<&[u8], 3>::new( + 4.try_into().unwrap(), + 4.try_into().unwrap(), + *&include_bytes!("3_4x4.imgbuf"), + ); + group.bench_function("overlay 3x3 offset", |bench| { + bench.iter(|| unsafe { + for x in 0..16 { + for y in 0..16 { + a.as_mut().overlay_at(&b, x * 4, y * 4); + } + } + }); + }); + assert_eq!(a.as_ref().buffer, include_bytes!("3x3_at_out.imgbuf")); + } + { + let mut a: Image<_, 3> = Image::alloc(64, 64); + let b = Image::<&[u8], 4>::new( + 4.try_into().unwrap(), + 4.try_into().unwrap(), + *&include_bytes!("4_4x4.imgbuf"), + ); + group.bench_function("overlay 4x3 offset", |bench| { + bench.iter(|| unsafe { + for x in 0..16 { + for y in 0..16 { + a.as_mut().overlay_at(&b, x * 4, y * 4); + } + } + }); + }); + + assert_eq!(a.as_ref().buffer, include_bytes!("4x3_at_out.imgbuf")); + } + { + let mut a: Image<_, 4> = Image::alloc(64, 64); + let b = Image::<&[u8], 4>::new( + 4.try_into().unwrap(), + 4.try_into().unwrap(), + *&include_bytes!("4_4x4.imgbuf"), + ); + group.bench_function("overlay 4x4 offset", |bench| { + bench.iter(|| unsafe { + for x in 0..16 { + for y in 0..16 { + a.as_mut().overlay_at(&b, x * 4, y * 4); + } + } + }); + }); + assert_eq!(a.as_ref().buffer, include_bytes!("4x4_at_out.imgbuf")); + } + group.finish(); +} + +criterion_group!(benches, criterion_benchmark); +criterion_main!(benches); diff --git a/src/overlay.rs b/src/overlay.rs index c1cac44..d1211a9 100644 --- a/src/overlay.rs +++ b/src/overlay.rs @@ -170,81 +170,3 @@ impl OverlayAt> for Image<&mut [u8], 4> { self } } - -#[cfg(test)] -mod bench { - extern crate test; - - use test::Bencher; - - use super::*; - use crate::{FromRef, FromRefMut}; - - #[bench] - fn overlay_3on3at(bench: &mut Bencher) { - let mut v = vec![0u8; 3 * 64 * 64]; - let mut a: Image<_, 3> = Image::new( - 64.try_into().unwrap(), - 64.try_into().unwrap(), - v.as_mut_slice(), - ); - let b = Image::<&[u8], 3>::new( - 4.try_into().unwrap(), - 4.try_into().unwrap(), - *&include_bytes!("../test_data/3_4x4.imgbuf"), - ); - bench.iter(|| unsafe { - for x in 0..16 { - for y in 0..16 { - a.overlay_at(&b, x * 4, y * 4); - } - } - }); - assert_eq!( - a.as_ref().buffer, - include_bytes!("../test_results/3x3_at_out.buf") - ); - } - - #[bench] - fn overlay_4on3at(bench: &mut Bencher) { - let mut a: Image<_, 3> = Image::alloc(64, 64); - let b = Image::<&[u8], 4>::new( - 4.try_into().unwrap(), - 4.try_into().unwrap(), - *&include_bytes!("../test_data/4_4x4.imgbuf"), - ); - bench.iter(|| unsafe { - for x in 0..16 { - for y in 0..16 { - a.as_mut().overlay_at(&b, x * 4, y * 4); - } - } - }); - assert_eq!( - a.as_ref().buffer, - include_bytes!("../test_results/4x3_at_out.buf") - ); - } - - #[bench] - fn overlay_4on4at(bench: &mut Bencher) { - let mut a: Image<_, 4> = Image::alloc(64, 64); - let b = Image::<&[u8], 4>::new( - 4.try_into().unwrap(), - 4.try_into().unwrap(), - *&include_bytes!("../test_data/4_4x4.imgbuf"), - ); - bench.iter(|| unsafe { - for x in 0..16 { - for y in 0..16 { - a.as_mut().overlay_at(&b, x * 4, y * 4); - } - } - }); - assert_eq!( - a.as_ref().buffer, - include_bytes!("../test_results/4x4_at_out.buf") - ); - } -}