From fce3fa5210fb5b343725cee23408976bee0a8f04 Mon Sep 17 00:00:00 2001
From: Erin <erin@erindesu.cz>
Date: Mon, 24 Jul 2023 16:48:13 +0200
Subject: [PATCH] fixed imm shl/r

---
 hbvm/src/vm/mod.rs | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/hbvm/src/vm/mod.rs b/hbvm/src/vm/mod.rs
index 33fdd60..ce1096e 100644
--- a/hbvm/src/vm/mod.rs
+++ b/hbvm/src/vm/mod.rs
@@ -48,19 +48,16 @@ macro_rules! binary_op {
             ),
         );
     }};
-}
 
-/// Parform bitshift operations
-macro_rules! binary_op_sh {
-    ($self:expr, $ty:ident, $handler:expr) => {{
+    ($self:expr, $ty:ident, $handler:expr, $con:ty) => {{
         let ParamBBB(tg, a0, a1) = param!($self, ParamBBB);
         $self.write_reg(
             tg,
             $handler(
                 Value::$ty(&$self.read_reg(a0)),
-                $self.read_reg(a1).as_u64() as u32,
-            )
-        )
+                Value::$ty(&$self.read_reg(a1)) as $con,
+            ),
+        );
     }};
 }
 
@@ -73,6 +70,14 @@ macro_rules! binary_op_imm {
             $handler(Value::$ty(&$self.read_reg(a0)), Value::$ty(&imm.into())),
         );
     }};
+
+    ($self:expr, $ty:ident, $handler:expr, $con:ty) => {{
+        let ParamBBD(tg, a0, imm) = param!($self, ParamBBD);
+        $self.write_reg(
+            tg,
+            $handler(Value::$ty(&$self.read_reg(a0)), Value::$ty(&imm.into()) as $con),
+        );
+    }};
 }
 
 /// Jump at `#3` if ordering on `#0 <=> #1` is equal to expected
@@ -182,9 +187,9 @@ impl<'a, PfHandler: HandlePageFault, const TIMER_QUOTIENT: usize>
                     AND => binary_op!(self, as_u64, ops::BitAnd::bitand),
                     OR => binary_op!(self, as_u64, ops::BitOr::bitor),
                     XOR => binary_op!(self, as_u64, ops::BitXor::bitxor),
-                    SL => binary_op_sh!(self, as_u64, u64::wrapping_shl),
-                    SR => binary_op_sh!(self, as_u64, u64::wrapping_shr),
-                    SRS => binary_op_sh!(self, as_i64, i64::wrapping_shr),
+                    SL => binary_op!(self, as_u64, u64::wrapping_shl, u32),
+                    SR => binary_op!(self, as_u64, u64::wrapping_shr, u32),
+                    SRS => binary_op!(self, as_i64, i64::wrapping_shr, u32),
                     CMP => {
                         // Compare a0 <=> a1
                         // < → -1
@@ -234,9 +239,9 @@ impl<'a, PfHandler: HandlePageFault, const TIMER_QUOTIENT: usize>
                     ANDI => binary_op_imm!(self, as_u64, ops::BitAnd::bitand),
                     ORI => binary_op_imm!(self, as_u64, ops::BitOr::bitor),
                     XORI => binary_op_imm!(self, as_u64, ops::BitXor::bitxor),
-                    SLI => binary_op_imm!(self, as_u64, ops::Shl::shl),
-                    SRI => binary_op_imm!(self, as_u64, ops::Shr::shr),
-                    SRSI => binary_op_imm!(self, as_i64, ops::Shr::shr),
+                    SLI => binary_op_imm!(self, as_u64, u64::wrapping_shl, u32),
+                    SRI => binary_op_imm!(self, as_u64, u64::wrapping_shr, u32),
+                    SRSI => binary_op_imm!(self, as_i64, i64::wrapping_shr, u32),
                     CMPI => {
                         let ParamBBD(tg, a0, imm) = param!(self, ParamBBD);
                         self.write_reg(