From b7ec1d11658e334454ae476c0dcda5677de6c320 Mon Sep 17 00:00:00 2001
From: griffi-gh <prasol258@gmail.com>
Date: Sat, 18 Feb 2023 00:38:09 +0100
Subject: [PATCH] fix order

---
 kubi-shared/src/worldgen.rs | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/kubi-shared/src/worldgen.rs b/kubi-shared/src/worldgen.rs
index 954293e..382b094 100644
--- a/kubi-shared/src/worldgen.rs
+++ b/kubi-shared/src/worldgen.rs
@@ -119,18 +119,21 @@ pub fn generate_world(chunk_position: IVec3, seed: u64) -> (BlockData, Vec<Queue
       let height = {
         let local_elevation = raw_elevation_value.powi(4).sqrt();
         let mut height = (mountain_ramp(raw_heightmap_value) * local_elevation * 100.) as i32;
+        //Flatten valleys
+        if height < 0 {
+          height /= 2; 
+        }
         //Generate rivers
         {
           let river_value = river_noise.get_noise(noise_x, noise_y);
           if (-0.00625..0.00625).contains(&(river_value.powi(2))) {
             is_surface = false;
             river_fill_height = Some(height);
-            height -= (20. * (0.00625 - river_value.powi(2)) * (1. / 0.00625)).round() as i32;
+            height -= (15. * (0.00625 - river_value.powi(2)) * (1. / 0.00625)).round() as i32;
           }
         }
+        //Generate ravines
         if height < 0 {
-          height /= 2; //Flatten valleys
-          //Generate ravines
           if raw_ravine_location_value > 0.4 {
             let raw_ravine_value = ravine_nose_line.get_noise(noise_x, noise_y);
             if (-0.0125..0.0125).contains(&(raw_ravine_value.powi(2))) {