From e73b336670905d02ee893ef2b894804794b42c49 Mon Sep 17 00:00:00 2001
From: griffi-gh <prasol258@gmail.com>
Date: Tue, 14 May 2024 00:08:27 +0200
Subject: [PATCH] fix needless SmUniformData updates

---
 kubi/src/rendering/smoverlay.rs         | 2 +-
 kubi/src/rendering/smoverlay/uniform.rs | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/kubi/src/rendering/smoverlay.rs b/kubi/src/rendering/smoverlay.rs
index e0e66fc..a81907c 100644
--- a/kubi/src/rendering/smoverlay.rs
+++ b/kubi/src/rendering/smoverlay.rs
@@ -24,7 +24,7 @@ pub fn render_submerged_view(
   state: UniqueView<SmOverlayRenderState>,
   buf: UniqueView<FstriPrimitive>,
 ) {
-  if state.uniform.stored_data.is_none() { return }
+  if !state.uniform.internal_do_render_flag { return }
 
   let mut rpass = ctx.encoder.begin_render_pass(&wgpu::RenderPassDescriptor {
     label: Some("smoverlay_render_pass"),
diff --git a/kubi/src/rendering/smoverlay/uniform.rs b/kubi/src/rendering/smoverlay/uniform.rs
index c859739..756e988 100644
--- a/kubi/src/rendering/smoverlay/uniform.rs
+++ b/kubi/src/rendering/smoverlay/uniform.rs
@@ -11,7 +11,8 @@ pub struct SmUniformData {
 }
 
 pub struct SmUniform {
-  pub stored_data: Option<SmUniformData>,
+  pub internal_do_render_flag: bool,
+  stored_data: Option<SmUniformData>,
   pub buffer: wgpu::Buffer,
   pub bind_group_layout: wgpu::BindGroupLayout,
   pub bind_group: wgpu::BindGroup,
@@ -53,6 +54,7 @@ pub fn init_sm_uniform(
   });
 
   SmUniform {
+    internal_do_render_flag: false,
     stored_data: None,
     buffer,
     bind_group_layout,
@@ -67,7 +69,7 @@ pub fn update_sm_uniform(
   trans: View<Transform>,
   world: UniqueView<ChunkStorage>,
 ) {
-  state.uniform.stored_data = None;
+  state.uniform.internal_do_render_flag = false;
 
   let (_, plr_trans) = (&plr, &trans).iter().next().expect("Main player MIA");
   let plr_pos = plr_trans.0.to_scale_rotation_translation().2;
@@ -79,6 +81,7 @@ pub fn update_sm_uniform(
     color: color.to_array()
   };
 
+  state.uniform.internal_do_render_flag = true;
   if state.uniform.stored_data == Some(new_data) {
     return
   }